Skip to content

OSDOCS#13407: Cert-manager release notes for 1.14.2 version#91902

Closed
subhtk wants to merge 1 commit intoopenshift:mainfrom
subhtk:osdocs13407
Closed

OSDOCS#13407: Cert-manager release notes for 1.14.2 version#91902
subhtk wants to merge 1 commit intoopenshift:mainfrom
subhtk:osdocs13407

Conversation

@subhtk
Copy link
Contributor

@subhtk subhtk commented Apr 9, 2025 •
edited
Loading

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 9, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 9, 2025 •
edited
Loading

🤖 Wed Apr 09 09:59:51 - Prow CI generated the docs preview:

https://91902--ocpdocs-pr.netlify.app/openshift-enterprise/latest/security/cert_manager_operator/cert-manager-operator-release-notes.html

swghosh
swghosh suggested changes Apr 9, 2025
View reviewed changes
security/cert_manager_operator/cert-manager-operator-release-notes.adoc Outdated
* link:https://access.redhat.com/errata/RHEA-2025:3725[RHEA-2025:3725]
* link:https://access.redhat.com/errata/RHSA-2025:3714[RHSA-2025:3714]

Version `1.14.2` of the {cert-manager-operator} is based on the upstream cert-manager version `v1.14.5`. For more information, see the link:https://cert-manager.io/docs/releases/release-notes/release-notes-1.14/#v1145[cert-manager project release notes for v1.14.5].
Copy link
Member

@swghosh swghosh Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Version `1.14.2` of the {cert-manager-operator} is based on the upstream cert-manager version `v1.14.5`. For more information, see the link:https://cert-manager.io/docs/releases/release-notes/release-notes-1.14/#v1145[cert-manager project release notes for v1.14.5].
Version `1.14.2` of the {cert-manager-operator} is based on the upstream cert-manager version `v1.14.7`. For more information, see the link:https://cert-manager.io/docs/releases/release-notes/release-notes-1.14/#v1147[cert-manager project release notes for v1.14.7].

@swghosh
Copy link
Member

swghosh commented Apr 9, 2025

Please do not add these changes to 4.19 and 4.18, we've to ensure this is only added to v4.14-v4.17.

@subhtk
Copy link
Contributor Author

subhtk commented Apr 9, 2025

@lunarwhite can you ptal?

lunarwhite
lunarwhite reviewed Apr 9, 2025
View reviewed changes
Copy link
Member

@lunarwhite lunarwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@lunarwhite
Copy link
Member

lunarwhite commented Apr 9, 2025 •
edited
Loading

Please do not add these changes to 4.19 and 4.18, we've to ensure this is only added to v4.14-v4.17.

@subhtk You may need to raise the PR against branch enterprise-4.17, and let the bot auto cherrypick onto 4.14 ~ 4.16, very similar to what we did for 1.14.1: #84397

@openshift-ci
Copy link

openshift-ci bot commented Apr 9, 2025

@subhtk: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@swghosh
Copy link
Member

swghosh commented Apr 9, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2025
@skopacz1 skopacz1 added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Apr 9, 2025
@skopacz1
Copy link
Contributor

skopacz1 commented Apr 9, 2025

@lunarwhite is correct, this PR needs to be closed and the content changes applied to a 4.17 branch. Any reviews done in this PR can be applied to that one, though, as long as the versions: selection stays the same. Once that PR is merged, I can try to cherry pick it to the earlier versions

@subhtk subhtk mentioned this pull request Apr 9, 2025
Merged
1 task
@lunarwhite
Copy link
Member

lunarwhite commented Apr 10, 2025

/close
PR #91932 got merged and doc page is live now

@openshift-ci openshift-ci bot closed this Apr 10, 2025
@openshift-ci
Copy link

openshift-ci bot commented Apr 10, 2025

@lunarwhite: Closed this PR.

Details

In response to this:

/close
PR #91932 got merged and doc page is live now

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@lunarwhite lunarwhite lunarwhite left review comments

@swghosh swghosh swghosh requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@swghosh swghosh

Labels

lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@subhtk @ocpdocs-previewbot @swghosh @lunarwhite @skopacz1